Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video widget display component in public page #1837

Merged
merged 13 commits into from
Jul 13, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Add video widget in engagement view page
  • Install react-player
  • Minor refactoring

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1837 (359811d) into main (bd80e5f) will decrease coverage by 0.06%.
The diff coverage is 43.90%.

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
- Coverage   70.89%   70.83%   -0.06%     
==========================================
  Files         405      406       +1     
  Lines       12327    12354      +27     
  Branches      923      925       +2     
==========================================
+ Hits         8739     8751      +12     
- Misses       3431     3446      +15     
  Partials      157      157              
Flag Coverage Δ
metapi 78.76% <100.00%> (+<0.01%) ⬆️
metweb 63.89% <41.02%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngagementWidgets/Subscribe/SubscribeOptionCard.tsx 60.00% <0.00%> (ø)
.../src/services/widgetService/VideoService/index.tsx 27.27% <0.00%> (+4.19%) ⬆️
.../engagement/view/widgets/Video/VideoWidgetView.tsx 32.14% <32.14%> (ø)
...t/form/EngagementWidgets/Video/VideoOptionCard.tsx 59.45% <50.00%> (ø)
met-api/src/met_api/constants/widget.py 100.00% <100.00%> (ø)
...EngagementWidgets/Documents/DocumentOptionCard.tsx 88.88% <100.00%> (ø)
...form/EngagementWidgets/Events/EventsOptionCard.tsx 86.48% <100.00%> (ø)
...ement/form/EngagementWidgets/Map/MapOptionCard.tsx 86.48% <100.00%> (ø)
...form/EngagementWidgets/Phases/PhasesOptionCard.tsx 88.88% <100.00%> (ø)
...idgets/WhoIsListening/WhoIsListeningOptionCard.tsx 88.88% <100.00%> (ø)
... and 1 more

@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 13, 2023 19:58
@jadmsaadaot jadmsaadaot merged commit 13a5eea into bcgov:main Jul 13, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Add video widget model and option card

* add video widget service and resource

* Add video widget crud and UI component

* Fix linting issue

* Add video widget display in engagement view

* improve service methods return

* Use some instead of map includes

* remove console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants